Add flag to fail fast when downloading .so during build #670
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keliramu
approved these changes
Oct 28, 2024
mariusSincovici
approved these changes
Oct 28, 2024
| @@ -43,6 +43,7 @@ function fetch_gitlab_artifact() { | |||
| curl \ | |||
| --retry 3 \ | |||
| --retry-delay 2 \ | |||
| --fail-with-body \ | |||
There was a problem hiding this comment.
Is it needed to save the document at failure? Or this is just for debugging?
There was a problem hiding this comment.
Just for debugging. We can go with just --fail without saving the body and the status of the http call should be enough to figure out what's wrong, but the status can be easily missed, so I left the --fail-with-body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
--fail-with-bodyto fail fast when downloading dependencies